#9910 Impact check for Changes/Enable_Spec_File_Preprocessing
Closed: Fixed 3 years ago by mohanboddu. Opened 3 years ago by clime.

Hello,

for the the change https://fedoraproject.org/wiki/Changes/Enable_Spec_File_Preprocessing I would need the following line to be added to mock configuration of Koji builders:

config_opts['plugin_conf']['rpkg_preprocessor_enable'] = True

so that the rpkg preprocessor plugin is enabled on infrastructure level. Also mock version >= 2.7 is required as 2.7 is the version where the preprocessor was introduced.

Thank you for taking a look at this!


What about the 'cmd' and 'requires' options? Do those also need to be specified?

If they are not specified, they default to:

config_opts['plugin_conf']['rpkg_preprocessor_opts']['requires'] = ['preproc-rpmspec']
config_opts['plugin_conf']['rpkg_preprocessor_opts']['cmd'] = '/usr/bin/preproc-rpmspec %(source_spec)s --output %(target_spec)s'

which is correct.

These options were added just in case there is some future change in the tooling so that only configs will need to be changed and not the plugin code itself.

We recently downgraded mock to 2.6 due to an issue and the fix is built in mock-2.8-1. We need to update mock to 2.8 on all the builders then apply this config.

I suggest making this change after new year as I dont want to break koji (if in case) just before holidays.

Also, releng uses rpmdev-bumpspec for mass rebuilds, we need to make sure that it got updated before the mass rebuild.

Metadata Update from @mohanboddu:
- Issue tagged with: change-ack, changes, f34, low-trouble, mass rebuild, medium-gain, ops

3 years ago

Since the change got rejected, we are closing this ticket.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Log in to comment on this ticket.

Metadata
Boards 1
Ops Status: Done