Learn more about these different git repos.
Other Git URLs
Hi, today I had to disable centpkg's pre_push_check because it didn't like the name of the branch I had created:
$ centpkg pre-push-check Could not execute pre_push_check: Branchname: mcatanzaro/portal-helper-c8s is not valid
I have no clue what it doesn't like about the branch name because it does not say. I failed to find the code that implemented the branch name checking. In particular, there are no hits for "Could not execute" or "Branchname" anywhere in the rpkg repo, so I presume the error is coming from some dependency.
The pre-push check contains many useful checks, and it's a shame to lose them.
That check happens in centpkg itself: https://git.centos.org/centos/centpkg/blob/develop/f/src/centpkg/__init__.py#_88
centpkg
Each application that uses rpkg is free to define their own rules for branch names. I suggest you close this issue and refile for centpkg and/or open discussion in whatever discussion platform CentOS uses.
rpkg
ack, thanks. That explains why I couldn't find the code....
Metadata Update from @catanzaro: - Issue close_status updated to: Invalid - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.