rpkg

#188 Rewrite tests to avoid running rpmbuild and rpmlint
Merged by cqi. Opened by cqi.
cqi/rpkg fix-tests  into  master

Download 188.patch

This patch makes tests not depend on specific platforms where tests
run.

This patch also fixes prep, install, compile, local, verify-files where
not modify rpmdefines by adding _builddir.

Signed-off-by: Chenxiong Qi cqi@redhat.com

I agree changing self.rpmdefines here seems wrong. However, this changes the order. Since the rpmdefines contain _builddir, it will override what is appended here. I think it breaks the --builddir cli option.

Typo here: warining. Given that the command is not actually executed, does it make sense to mangle the specfile? I think just testing the --info option would be enough.

rebased

@lsedlar Fixed. Thanks for pointing out these.

Looks good to me. :thumbsup:

rebased

Looks good to me.

I'll rebase this patch, then merge it.

rebased

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.