rpkg

#219 Allow customizing container build target
Merged by lsedlar. Opened by lsedlar.
lsedlar/rpkg container_namespace  into  master

Download 219.patch

This is a pretty much a variation of #214: it breaks the ns_module_name property up into separate module name and namespace.

Another commit adds a method that allows downstream clients to customize how build target for container build is determined. That would allow customizing the target in downstream clients.

The default is changed in the way proposed in #214.

rebased

3 new commits added

  • Allow overriding container build target by downstream
  • Add a separate property for namespace
  • Allow container builds from any namespace

Should docker be replaced with self.ns?

Good question. Using the namespace makes more sense, but it's a change from current status (right now the docker part is hardcoded).

IIRC, docker has been changed to container in build target.

Seems we need to handle the "migration" as someone could start container build on target f26-container-candidate from an old clone with docker namespace.

3 new commits added

  • Allow overriding container build target by downstream
  • Add a separate property for namespace
  • Allow container builds from any namespace

:thumbsup:

rebased

Pull-Request has been merged by lsedlar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.