rpkg

#242 cli: add --arches support for koji_cointainerbuild
Merged by cqi. Opened by mlangsdorf.
mlangsdorf/rpkg container_cli_arches  into  master

Download 242.patch

add support for reading --arches for koji_containerbuilds and passing the
argument on.

Signed-off-by: Mark Langsdorf mlangsdo@redhat.com

Test case TestContainerBuildWithKoji fails.

rebased

Fixed.

Looks good to me. Tests pass.

I'm a bit confused about why rpkg still has code for talking directly to osbs (see the __init__.py changes). Didn't we remove that?
Edited by twaugh

rebased onto b0932a9ae1a4894b7fcc1f574a79fca385e59e12

I'm a bit confused about why rpkg still has code for talking directly to osbs (see the init.py changes). Didn't we remove that?

@twaugh, no, we never did. I'll file a story to get it cleaned up.

+1

+1

Tests pass. Merging.

Pull-Request has been merged by cqi

Why not "arch_override"?

Should this complain when self.args.arches is set but self.args.scratch is not, or is that up to the Koji plugin? Something ought to complain -- right now the arch_override list is just ignored for non-scratch builds.

Should this complain when self.args.arches is set but self.args.scratch is not, or is that up to the Koji plugin?

For more concise handling, I think it should be done in osbs-client prior to OpenShift build creation. Will file a story.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.