#246 Remove unsupported osbs for container-build
Merged by lsedlar. Opened by lucarval.
lucarval/rpkg removed-unsupported-osbs-build  into  master

Download 246.patch

The osbs build method for container-build has not been
supported for quite a while.

Signed-off-by: Luiz Carvalho lucarval@redhat.com

@twaugh, @cqi PTAL

There are flake8 errors detected in Jenkins job, and some tests fails.

OSBS_DEFAULT_CONF_FILE and osbs_config_filename in cli.py and __init__.py are not required anymore.

rebased onto cc32976fb1c7bdddc9b5ec12dd29909d3ab154af

rebased onto 2ad11354dc5af0ce97007ccd0b0556e35ee74e80

@cqi, thanks!

Fixed flake8 errors.
Fixed broken tests (build-with is no longer a valid argument).
Removed unneeded OSBS_DEFAULT_CONF_FILE.

Didn't remove osbs_config_filename because it's still used by container-build-setup command.

@lucarval Thank you.

Looks container_build_setup is for writing osbs config file. .osbs-repo-config seems not useful for building containers via Koji containerbuild plugin? If yes, I think it can be removed as well.

@cqi, that file is actually used by OSBS during build time. A build submitted via Koji still uses OSBS behind the scenes. The difference is that Koji builder is the one that has direct access to OSBS infrastructure, instead of the client.

@lucarval I see. Thanks for your explanation. This PR looks good to me. :thumbsup:

@cqi, @lsedlar, can this be merged?

Pull-Request has been merged by lsedlar

Metadata