rpkg

#247 Fix arch-override for container-build
Merged by cqi. Opened by lucarval.
lucarval/rpkg arch-override  into  master

Download 247.patch

The buildContainer task of koji-containerbuild expects
the task options "arch_override", not "arches". It also
expects the value to be a space separated string. Both of
these are also similar to how the regular build command
is defined.

Signed-off-by: Luiz Carvalho lucarval@redhat.com

ptal @twaugh, @cqi, @vrutkovs

LGTM

Looks good to me.

In addition, instead of mapping arches to arch_override, how about rename --arches to some name to reflect the meaning of arch_override directly?

The argument should be called --arches for compatibility with build subcommand. They do the same thing, and so they should be called the same name.

The argument should be called --arches for compatibility with build subcommand.

@lsedlar, the cli argument is --arches. But it's converted to arch_override task option, which is the same approach used by the regular build command.

Update: I realize now your comment was intended to clarify that we should keep arches mapping to arch_override. Sorry for the noise. :)
Edited by lucarval

Ok. I'm going to merge. Thank you all. :)

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.