#270 Add compose-id and signing-intent arguments
Merged by cqi. Opened by bfontecc.
bfontecc/rpkg params  into  master

Download 270.patch

Please also see the corresponding change to rhpkg.

Signed-off-by: Bret Fontecchio bfontecc@redhat.com

Let's follow the same format used for --repo-url:

        self.container_build_parser.add_argument(
            '--repo-url',
            metavar="URL",
            help=('URL of yum repo file'),
            nargs='*')

default=None is redundant. Let's just remove it.

dest in this case is redundant, --signing-intent gets automatically converted to signing_intent.

rebased onto 9f1a732273f5ca68e68016f66607ef0d487b26e8

This trailing space should be kept here.

This should not happen because of the group group = self.container_build_parser.add_mutually_exclusive_group() that prevents from using --compose-id and --signing_intent at same time.

I'm thinking if we can give same command line arguments error UX when giving both --compose-id and --repo-url.

I agree with all of cqi's comments. Let's remove the unnecessary explicit check for mutually exclusivity, as well as, add repo-url to the mutually exclusive group added.

rebased onto 87075bafc410d681d38fc393dbde046f759a3a74

rebased onto 69d2dc11ca92c7245aa8c45d04cee86b36e953aa

rebased onto 449aee72fb823ec53c776ec81306b612b7a4374d

rebased onto a97fc29389691d3fcfaeee67e347511f2bb1fb77

rebased onto 4cae8745c2b844970efe74f6b7c3abb212f0ed6c

rebased onto 00a8c40153b276a63088b7891f866f62161d6f5c

Looks good.

Looks good to me as well. Thank you. :thumbsup:

Looks good to me.

Can someone merge this?

Commit c2853f4c fixes this pull-request

Pull-Request has been merged by cqi

Pull-Request has been merged by cqi

Metadata