#28 Add the possibility to clone a module to a specified directory
Closed by lsedlar. Opened by pingou.
pingou/rpkg git_clone_target  into  master

Download 28.patch
no initial comment

Fixes https://pagure.io/fedpkg/issue/9

I thought of something this morning. at least in the past the directory name was used to work out the name of the module. we will need to make sure that if we clone into a different directory we do not break anything

Looks like rpkg does rely on the directory name to figure out the name of the git/package: https://pagure.io/rpkg/blob/master/f/src/pyrpkg/cli.py#_64

so we will need to do something else. either disallow this change, or fix up rpkg so that it uses some other method to figure out the module name

The line linked by @pingou tries to determine name of the executed script (fedpkg, rhpkg etc.), not the name of the module. There is a load_module_name method that loads the name from git config, with a fall back to spec file.

Pull-Request has been updated

I have rebased this on master and added a few tweaks as #58. Maybe @cqi can help with review before merging.

Pull-Request has been closed by lsedlar

Metadata