PR#293: Change default rpmlint configuration file -

rpkg

#293 Change default rpmlint configuration file

Merged Mar 21, 2018 by cqi. Opened Feb 18, 2018 by athoscr.

athoscr/rpkg change-default-lint-config into master

athoscr commented Feb 18, 2018

Current rpmlint configuration file (.rpmlint) is hidden. Making the file
visible may encourage packagers looking at other repositories to
properly configure rpmlint runs and omit false positives. This commit
makes .rpmlintrc the default configuration file and
triggers a deprecation message whenever a .rpmlint file is implicitly
used.

Signed-off-by: Athos Ribeiro athoscr@fedoraproject.org

ngompa commented Feb 19, 2018

:thumbsup:

rebased onto a823b8d1164b1ea18ac04905dc8a137e6dae302e

Feb 19, 2018

ralph commented Feb 22, 2018

Good idea.

athoscr commented Feb 23, 2018

The idea came up in a discussion in fedora-devel mailing lists (I had no part in the discussion, but I did like the idea).

kparal commented Feb 23, 2018

I haven't found any place where this config file is mentioned (except for fedpkg man page, which is not linkable), so I went ahead and added a note at https://fedoraproject.org/wiki/Package_maintenance_guide (next to fedpkg lint). I used this new name already.

Also please note we added support for the same config name in task-rpmlint (shown in bodhi):
https://pagure.io/taskotron/task-rpmlint/issue/5

cqi commented Feb 24, 2018

Please use property self.module_name.

cqi commented Feb 24, 2018

Please also add a test for the new default rpmlintconf. There is already a test case TestLint containing some tests for lint command. The new test could be added to that test case class.

rebased onto b00462405174e789f01b675c4023948dadda2dde

Feb 25, 2018

rebased onto 5a8cac41b2cb588fd4c83837c4446b13f4449937

Feb 25, 2018

athoscr commented Feb 25, 2018

I addressed the requested points and changed some documentation I missed in the first patch.

cqi commented Feb 26, 2018

This should be the problem detected by Jenkins job.

athoscr commented Feb 26, 2018

I forgot checking the test file after adding the last tests. Fixed.

rebased onto 3cdbbb70eb17adbd84806a672df6170e6108314d

Feb 26, 2018