#320 Require dependent rpm properly
Closed by cqi. Opened by cqi.
cqi/rpkg fix-require-to-rpm  into  master

Download 320.patch

Fixes rhbz#1579367

Signed-off-by: Chenxiong Qi cqi@redhat.com

LGTM given that that koji will be patched/seded out in Fedora spec for now.

@churchyard There are new builds with this patch and patched koji in https://copr.fedorainfracloud.org/coprs/cqi/test-rpkg-packaging/build/756007/

There are also fedpkg builds which requires >=1.54-2 in https://copr.fedorainfracloud.org/coprs/cqi/test-fedpkg-packaging/build/756014/

I tested some commands in Fedora 28, that work well.

ok, let's push it?

Looks good to me.

Unfortunately, while testing this patch in EL6 and EL7, it still fails. Because, there is only old rpm-python, which does not have the rpm egginfo.

I think the solution should be to remove koji and rpm-py-installer and not require rpm, which was proposed by @churchyard. I'd like to keep current install_requires unchanged in rpkg upstream Python package, just patch it in RPM spec to remove koji and rpm-py-installer. I've been testing the patch now, and make a PR soon.

Pull-Request has been closed by cqi

Metadata