rpkg

#356 Fix a bad test teardown
Merged by cqi. Opened by otaylor.
otaylor/rpkg test-teardown  into  master

Download 356.patch

Calling .stop() on the mock object rather than the patcher left pyrpkg.log
pointing to the mock object, which caused test_check_repo_has_namespace()
to fail since it was expecting a particular message to be logged to stderr.

No idea why this isn't failing for other people - 

$ pip show pytest mock
Name: pytest
Version: 3.2.3
Name: mock
Version: 2.0.0

which are the F27 versions.

Ah - I hit the problem because I was running the tests under pytest rather than under nosetests - this still should make sense as a fix.

Good catch. Thank you very much.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.