#392 Validate the module build optional argument when parsing the argument
Merged by onosek. Opened by mprahl.
Unknown source master

Download 392.patch

As discussed in IRC, this moves the validation of the optional argument to when it is parsed by argparse.

@lsedlar and @cqi could you please review?

rebased onto f58c12f2617950bd2c38a5ac6821e6d8cdaaafa5

validate_module_build_optional already returns a tuple of key and value.

Maybe parameter description in docstring also needs to be updated

:param optional: an optional list of "key=value" to be passed in with
    the MBS build submission.

Oops, I missed this. I'll fix that.

rebased onto 607b1fbb2dcce2a139b4cb64c61e6072b9a0b880

@cqi fixed. Thanks for the review.

It looks OK for me.

Pull-Request has been merged by onosek

Metadata