rpkg

#408 Remove koji and rpm-py-installer from requires
Closed by onosek. Opened by onosek.
onosek/rpkg setup_py_patch  into  master

Download 408.patch

Fix for bug 1579367
Due to https://pagure.io/koji/issue/912, python[23]-koji package does not
have egginfo.
rpm-py-installer is required as a proxy to install RPM python binding
library, so rpm is the actual requirement that must be present in the
requires.txt. But, rpkg has to work in all active Fedora and EPEL releases,
and there is only old rpm-python package in EL6 and 7, so just simply to
remove rpm-py-installer for now.

Resolves: rhbz#1579367
Relates: https://pagure.io/koji/issue/912

Signed-off-by: Ondrej Nosek onosek@redhat.com

@cqi Does make sense to apply this patch into code or is better to keep it in spec file?
Currently, it is even in RHEL8 spec file. Is it related to RHEL8 also?

I would suggest to keep it in SPEC. From my perspective, rpkg firstly is delivered as a Python distribution, so koji is required in the install_requires list. When deliver rpkg in Fedora, that Python package will be an upstream to the RPM package, then any necessary changes to build a RPM and work with other required RPMs should be made in SPEC.

py-rpm-installer is a special case indeed. Currently, it is listed in tox.ini for running tests only. README also mentions to install it manually if user installs rpkg in a Python virtual environment created without --system-site-packages.

Hopefully, koji#912 could be released as soon as possible in order to ease the RPM package maintenance.

BTW, https://src.fedoraproject.org/rpms/rpkg/blob/master/f/remove-koji-and-rpm-py-installer-from-requires.patch could be updated to just remove koji because as mentioned, py-rpm-installer is no longer a requirement listed in rpkg Python package. On the other hand, koji could be removed from rpkg requires.txt that was suggested Lubomir, which should be a better solution than applying a patch.

rebased onto 5d86e1b23189442026dbcb8fa4aef5710654c376

Pull-Request has been closed by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.