PR#41: pyrpkg: use git remote get-url --push -

rpkg

#41 pyrpkg: use git remote get-url --push

Merged Apr 14, 2016 by lsedlar. Opened Apr 4, 2016 by mathstuf.

mathstuf/rpkg use-remote-get-url into master

no initial comment

mathstuf commented Apr 4, 2016

git 2.7.0 introduced the git remote get-url command which expands insteadOf aliases. This fixes the false warning for fedora:mypkg when fedora: is rewritten to a properly namespaced URL.

lsedlar commented Apr 4, 2016

Thanks. The change looks good to me. Could you please sign off on your commit? (git commit -s).

pbabinca commented Apr 4, 2016

Please do not add hard dependency on git 2.7 features which is fairly new (october 2015).

mathstuf commented Apr 4, 2016

It falls back to the old code if it fails for whatever reason.

mathstuf commented Apr 4, 2016

The commit is now signed-off-by.

Pull-Request has been rebased

Apr 4, 2016

mathstuf commented Apr 14, 2016

Ping?

Pull-Request has been merged by lsedlar

Apr 14, 2016

Metadata

Assignee

None

Tags

No Tags

rpkg

#41 pyrpkg: use git remote get-url --push Merged Apr 14, 2016 by lsedlar. Opened Apr 4, 2016 by mathstuf. mathstuf/rpkg use-remote-get-url into master

Metadata

#41 pyrpkg: use git remote get-url --push

Merged Apr 14, 2016 by lsedlar. Opened Apr 4, 2016 by mathstuf.

mathstuf/rpkg use-remote-get-url into master