PR#430: Pass --disablerepo and --enablerepo to mock -

rpkg

#430 Pass --disablerepo and --enablerepo to mock

Merged Apr 2, 2019 by onosek. Opened Apr 1, 2019 by onosek.

onosek/rpkg mock_disablerepo into master

Download 430.patch

onosek commented Apr 1, 2019

Mockbuild: pass arguments '--disablerepo' and '--enablerepo' to 'mock'
command.

JIRA: COMPOSE-3367
Fixes: https://pagure.io/fedpkg/issue/313

Signed-off-by: Ondrej Nosek onosek@redhat.com

lsedlar commented Apr 1, 2019

Looks good. I think it would be nice to enable passing this option multiple times. Mock supports it as well.

As an alternative, would it make sense to accept any arguments to mockbuild commands, and whatever is not consumed by *pkg would be passed to mock?

rebased onto 03e7e44789420f2158936ae2cb8ddd6eef295210

Apr 1, 2019

onosek commented Apr 1, 2019

Thanks for notifying me about argument repetition. I submitted a new version to implement this.
But I am afraid to do the second suggestion. It could be quite tough as parse_args call is in the code just once.

rebased onto f0d0f57a596b178642d3388135e0f6dd7a276b26

Apr 2, 2019

Pull-Request has been merged by onosek

Apr 2, 2019

Metadata

Assignee

None

Tags

No Tags

rpkg

#430 Pass --disablerepo and --enablerepo to mock Merged Apr 2, 2019 by onosek. Opened Apr 1, 2019 by onosek. onosek/rpkg mock_disablerepo into master

Metadata

#430 Pass --disablerepo and --enablerepo to mock

Merged Apr 2, 2019 by onosek. Opened Apr 1, 2019 by onosek.

onosek/rpkg mock_disablerepo into master