rpkg

#435 Allow passing --offline and -r to mbs-manager build_module_locally.
Merged by onosek. Opened by jkaluza.
jkaluza/rpkg mbs-offline-builds  into  master

Download 435.patch

It is now possible to build modules offline without any external
infrastructure using the MBS. This is done by passing --offline
flag to mbs-manager and the list of repositories for the base
module.

In this commit, the support for these new flags (--offline and -r)
is added to pyrpkg.

Signed-off-by: Jan Kaluza jkaluza@redhat.com

With this PR, one can build module using fedpkg in offline mode using command similar to this:

$ fedpkg  module-build-local --offline --file ./testmodule.yaml --stream test -r /etc/yum.repos.d/fedora.repo -r /etc/yum.repos.d/fedora-updates.repo

Looks good to me. But I didn't test it.

does mbs-manager handle a situation when only one of --offline and -r arguments are given? There is no such check in rpkg.
Otherwise, I am OK with the code.

@onosek, Using --offline without -r is valid use-case. When using -r without --offline, the -r is ignored by mbs-manager. Maybe we should handle that case and exit in mbs-manager, but this should not be done in pyrpkg.

Oh, I see. Thanks.

Pull-Request has been merged by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.