PR#470: Improve reporting and avoid exceptions with module-build-watch -

rpkg

#470 Improve reporting and avoid exceptions with module-build-watch

Closed Dec 18, 2019 by merlinm. Opened Nov 1, 2019 by merlinm.

merlinm/rpkg module-build-reporting-fix into master

merlinm commented Nov 1, 2019

Currently, running fedpkg-stage module-build-watch 417 exits with the rather useless message Could not execute module_build_watch: 'rpms'. Although module build 417 in staging happened to fail during initialization of the build, fedpkg should report useful information about it. This PR makes a few tweaks so the actual failure message gets reported, and doesn't abort with a divide by zero exception.

csomh commented Dec 18, 2019

@merlinm so sorry, it seems that we totally missed this when we filed and merged #476 :-(

It had pretty much the same thing.

merlinm commented Dec 18, 2019

@csomh I'm just glad a fix to the issue has finally been merged!

I also just filed #479. If we wait, maybe someone else will eventually find and fix the same problem. :wink:

Pull-Request has been closed by merlinm

Dec 18, 2019

Metadata

Assignee

None

Tags

No Tags

rpkg

#470 Improve reporting and avoid exceptions with module-build-watch Closed Dec 18, 2019 by merlinm. Opened Nov 1, 2019 by merlinm. merlinm/rpkg module-build-reporting-fix into master

Metadata

#470 Improve reporting and avoid exceptions with module-build-watch

Closed Dec 18, 2019 by merlinm. Opened Nov 1, 2019 by merlinm.

merlinm/rpkg module-build-reporting-fix into master