PR#475: Add check for wrong repo name format during clone -

rpkg

#475 Add check for wrong repo name format during clone

Merged Dec 11, 2019 by onosek. Opened Dec 10, 2019 by onosek.

onosek/rpkg clone_repo_name into master

onosek commented Dec 10, 2019

"clone" method in fedpkg accepted repo name with .git extension. It cloned repo successfully, but during configuration of the repo it failed, because of wrong directory name derived from the repo name. Now rpkg checks (and modifies) the correct format at the beginning of the process.

Another commit in PR simplifies methods for getting namespace giturl. There were some unnecessary duplications.

lsedlar commented Dec 11, 2019

Why not double quotes and dropping the backslashes?

lsedlar commented Dec 11, 2019

Looks good to me.

onosek commented Dec 11, 2019

Why not double quotes and dropping the backslashes?

No clever reason. I will change it to double-quotes. Quotes in the file are already mixed.

2 new commits added

Add check for wrong repo name format during clone
Simplify methods for getting namespace giturl

Dec 11, 2019

Pull-Request has been merged by onosek

Dec 11, 2019

Metadata

Assignee

None

Tags

No Tags

rpkg

#475 Add check for wrong repo name format during clone Merged Dec 11, 2019 by onosek. Opened Dec 10, 2019 by onosek. onosek/rpkg clone_repo_name into master

Metadata

#475 Add check for wrong repo name format during clone

Merged Dec 11, 2019 by onosek. Opened Dec 10, 2019 by onosek.

onosek/rpkg clone_repo_name into master