PR#481: More transparent check of retired package -

rpkg

#481 More transparent check of retired package

Merged Mar 17, 2020 by onosek. Opened Jan 30, 2020 by onosek.

onosek/rpkg retire_check into master

onosek commented Jan 30, 2020

Code for that checking was moved into separate method.

Signed-off-by: Ondrej Nosek onosek@redhat.com

onosek commented Jan 30, 2020

The small change of the message will cause that fedpkg test (test_package_is_retired_already) will fail and therefore minor fix is needed. Will

if marker == 'dead.package':
   warn ...
elif marker == 'dead.module':
...

be better in this case?

lsedlar commented Jan 31, 2020

How about extracting the package or module string from the marker? Or storing both messages in a dict and picking the correct one based on the marker? Or just changing the message in tests as well?

onosek commented Mar 9, 2020

Extracting string from the marker ... that means I will keep the code as it is.

rebased onto b8979d010fcaf945f49a74719bab2defaf7ace4d

Mar 9, 2020

rebased onto 2707465f59206e65773c3ff7b412d09f217e80a9

Mar 13, 2020

lsedlar commented Mar 17, 2020

Looks good to me.

rebased onto 0dca4d91c2aedcddc55a20692d567c05b59bf823

Mar 17, 2020

rebased onto 0fba3ea31b0635a1490c5da31fb0a6aac56c28b4

Mar 17, 2020

Pull-Request has been merged by onosek

Mar 17, 2020

Metadata

Assignee

None

Tags

No Tags

rpkg

#481 More transparent check of retired package Merged Mar 17, 2020 by onosek. Opened Jan 30, 2020 by onosek. onosek/rpkg retire_check into master

Metadata

#481 More transparent check of retired package

Merged Mar 17, 2020 by onosek. Opened Jan 30, 2020 by onosek.

onosek/rpkg retire_check into master