PR#488: cli: additional warnings when using --release with container-build -

rpkg

#488 cli: additional warnings when using --release with container-build

Merged Mar 13, 2020 by onosek. Opened Mar 11, 2020 by mlangsdorf.

mlangsdorf/rpkg osbs7094 into master

mlangsdorf commented Mar 11, 2020

Fixes OSBS-7094

Add an additional warning when using --release with container-build that
the results may not be intented and that --target should be used instead.

Signed-off-by: Mark Langsdorf mlangsdo@redhat.com

rebased onto d804bc7dda6d6831aa9c9559ad66d7a81614ec82

Mar 12, 2020

onosek commented Mar 12, 2020

Isn't it late to display a warning when the container build is running? Is it expected that the user will terminate the build quickly when sees the warning?

mlangsdorf commented Mar 12, 2020

I can't see a way to warn them at any other time. They have to submit the flawed command before anything can happen.

onosek commented Mar 13, 2020

Ok, let's do this way you proposed.

onosek commented Mar 13, 2020

Commit d190d105 fixes this pull-request

Pull-Request has been merged by onosek

Mar 13, 2020

Metadata

Assignee

None

Tags

No Tags

rpkg

#488 cli: additional warnings when using --release with container-build Merged Mar 13, 2020 by onosek. Opened Mar 11, 2020 by mlangsdorf. mlangsdorf/rpkg osbs7094 into master

Metadata

#488 cli: additional warnings when using --release with container-build

Merged Mar 13, 2020 by onosek. Opened Mar 11, 2020 by mlangsdorf.

mlangsdorf/rpkg osbs7094 into master