Fix for the https://pagure.io/rpkg/issue/521
@onosek, @psabata, please, take a look.
+1, LGTM.
+1, looks good
:thumbsup:
For which tool it has to be fixed? In fedpkg, download_path from rpkg object is overridden (and it should work there): https://pagure.io/fedpkg/blob/master/f/fedpkg/lookaside.py Same for rhpkg.
download_path
Fixed for the: https://github.com/fedora-eln/distrobaker Thank you for the update, I'll take a look.
I was discussing the change. Probably, it is safe to merge it. But I am not 100% sure whether all dependent tools use overridding or the default path. It won't harm rhpkg, fedpkg, rfpkg. We don't know about centpkg or others (if there are any).
This (@bstinson) centpkg repo (https://bitbucket.org/bstinsonmhk/centpkg/src/master/src/centpkg/init.py) looks safe because they make their own url path. And overrides whole sources method.
sources
Commit 32be737f fixes this pull-request
Pull-Request has been merged by onosek
I additionally modified unittests.