rpkg

#560 Added 'remote' to rpkg from rhpkg
Merged by onosek. Opened by jkunstle.
jkunstle/rpkg add-remote  into  master

Download 560.patch

Users wanted the ability to add packages as remote
easily between different OS targets.

e.g. if one was updating a package for Fedora, they
might want to add the same package targetted for RHEL
as a remote.

This change adds this functionality, accomodating both
centpkg and fedpkg.

The intended functionality of this feature already exists
in a limited form in rhpkg, which will override the
work done in this change.

Fixes: https://pagure.io/fedpkg/issue/439
Jira: RHELCMP-5411

Signed-off-by: James Kunstle jkunstle@redhat.com

rebased onto 2f1596d1a239fe7078cfd57525ea683119828a17

rebased onto 2e9e4a81da9d9bab03b77d8731e6bf41787f4ecf

@onosek I changed state from (WIP), could I please have a code review?

rebased onto 7c8c6807b2b90f150711e4796cc8fa38f7c2013d

1 new commit added

  • Merge branch 'master' of https://pagure.io/rpkg into add-remote

1 new commit added

  • [WIP] Added 'remote' to rpkg from rhpkg

rebased onto ea8d2b9d3a5412214233dd4f9003759c8df6583e

rebased onto da9c14454526fa4716fb6868edbd27dad6493e0e

rebased onto 7454e3c2507b3a1059b67bc9975c25e3bbd7ceac

rebased onto 64c82ee34b497422f818e1d9b8743a87eff4a5ef

1 new commit added

  • [WIP] Added 'remote' to rpkg from rhpkg

rebased onto e542a19288f4c146f505afe90a9eb9b6385014c3

rebased onto 369464fe91509fbc0021a948d02af75f9324ae4a

rebased onto b184fca72b60d94ad6a292b52215b4f5dfd24301

rebased onto 7a876122eddf699e4baa41baa8068ff6c7d4c8a0

rebased onto 38fe3dec3bde5d264c92861f51b0640bbecef705

@onosek updated commit to reflect agreed-upon changes.

Probably it's better to remove this note. We don't know the default yet. Its value can change in the next lines.

Show warning to a user, that functionality is experimental, as it is in rhpkg.

Delete 2nd variant with TODO.

Does it worth having here some exception checking? What do you think? There is a more complicated (manual) variant of adding the remove in utils.py::do_add_remove. But maybe this easy call is sufficient for our purpose.

typo - 2x space

Does it worth having here some exception checking? What do you think? There is a more complicated (manual) variant of adding the remove in utils.py::do_add_remove. But maybe this easy call is sufficient for our purpose.

@onosek
I'm note sure what you mean in terms of "adding the remote in ...". I don't know what we're removing.

rebased onto 4ff22d1b45d2854f3a4a4156296c8f04373e7e2c

rebased onto 52517259fe372235045449e2fd0fc14e57f292d1

Does it worth having here some exception checking? What do you think? There is a more complicated (manual) variant of adding the remove in utils.py::do_add_remove. But maybe this easy call is sufficient for our purpose.

@onosek
I'm note sure what you mean in terms of "adding the remote in ...". I don't know what we're removing.

rpkg/utils.py::do_add_remote
vs
self._run_command(['git', 'remote', 'add', remote_name, anongiturl])

The simpler variant - self._run_command... don't have for example exception handling
We could call function do_add_remove instead of it, but it might be pointless for our intentions. I was just asking about your opinion.

Commit 7dc5e1a8 fixes this pull-request

Pull-Request has been merged by onosek

Let's omit the last comment of mine.
I merged the PR, because I think it was good enough. Thanks.
I only did some minor changes to the help section and added an info message about successful adding the remote.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.