Note that without this fix, we have problems in CentOS Stream 9, since the way git reflows the subject line sometimes causes it to have a line break between the Resolves: and bug ID portions, resulting in the commit being rejected by the gitbz_check gate.

Hi @sgallagh,

I check the code and tried the functionality. The implementation idea looks good. Commit messages that were generated didn't contain empty lines in any case I tested. And the message specified with "-m" argument was joined with the rest of the clog message:

$ rpmdev-bumpspec fedpkg.spec
$ fedpkg commit --with-changelog -m bbb

has produced the commit message:
bbbrebuilt

That's strange... it was working for me. I'll investigate and get back to you.

Okay, it looks like I misunderstood how file.writelines() works. Hopefully this version will be correct.

Yes, this was fixed.
Do you think, that the subject behaviour should be disabled with the current parameter --raw? If somebody wants raw input as the help says:
'Generate a more "raw" clog without twiddling the contents'.
I am not decided yet.

Yes, this was fixed.
Do you think, that the subject behaviour should be disabled with the current parameter --raw? If somebody wants raw input as the help says:
'Generate a more "raw" clog without twiddling the contents'.
I am not decided yet.

Yes, this was fixed.
Do you think, that the subject behaviour should be disabled with the current parameter --raw? If somebody wants raw input as the help says:
'Generate a more "raw" clog without twiddling the contents'.
I am not decided yet.

I would prefer not to allow this; the existence of extremely long subject lines is causing real-world problems that can be easily avoided by just moving that content into the body of the message.

I just rebased this to the latest upstream version. Could we get this landed soon?

Commit 778340c6 fixes this pull-request

I merged your request. I simply modified unittests to pass. Failures weren't shown because there is something wrong with the CentOS Jenkins instance.