rpkg

#668 mockbuild: use results/mock_* when results_dir=subdir
Merged by onosek. Opened by tmz.
tmz/rpkg mock-results-dir-subdir  into  master

Download 668.patch 
When results_dir=subdir most output and artifacts are stored under the
results directory.  Move the mock results dir from results_$pkgname to
avoid an extra, unnecessary top-level directory.

I was testing results_dir=subdir and found that having both results and results_$pkgname was a bit odd. I'm not sold on mock_$pkgname as the directory. I just think the mock results dir should be under the results dir when subdir is set.

I also looked briefly at whether this could/should be done in layouts, but I don't think it fits well there -- which I imagine is partly why mock_results_dir is not already defined in a layout.

When I wrote the ‘results_dir=subdir` some years ago,
I did not touch the mock results just to limit the initial scope.
I agree that they should go to the same place as other results, so I agree with this proposal.

You can argue about the aesthetics of the directory layout, of course.
I am fine what you propose, because it

  • achieves the main goal of having all the generated files under results and
  • is quite close to the results without specifying subdir

You are also right about the incompatibility between the layout system and how mock results are places.
Initially, there was a proposal on the devel mailing list that instead of a new directory for the results,
the results should go the existing mock results structure.
But I could not find a way to access they required values when the layout was being processed.

pretty please pagure-ci rebuild

rebased onto 6b8263272303336dce2cf607b4ab059418c3d1f5

Pull-Request has been merged by onosek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.