From 70418df0af51a2d21dc177e9cc69b3f154cf2e80 Mon Sep 17 00:00:00 2001 From: FeRD (Frank Dana) Date: Jul 14 2025 13:35:15 +0000 Subject: patch: Execute subprocess in text mode This prevents `fedpkg patch suffix` aborting with the error message "Could not execute patch: write() argument must be str, not bytes". Signed-off-by: FeRD (Frank Dana) --- diff --git a/pyrpkg/__init__.py b/pyrpkg/__init__.py index ad5ee31..724a4a4 100644 --- a/pyrpkg/__init__.py +++ b/pyrpkg/__init__.py @@ -2178,6 +2178,7 @@ class Commands(object): self.log.debug('Running %s', ' '.join(cmd)) (output, errors) = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, + text=True, cwd=self.path).communicate() except Exception as e: raise rpkgError('Error running gendiff: %s' % e)