#755 Improve performance of fedpkg upload
Merged by onosek. Opened by music.
music/rpkg new-sources-progress-performance  into  master

Download 755.patch

This is intended to fix https://bugzilla.redhat.com/show_bug.cgi?id=2387053 by throttling unnecessary terminal progress-bar updates.

Less significantly, but still somewhat usefully, it avoids setting up the progress bar callback at all when stdout is not a TTY.

I tested this locally in the sense that it doesn’t seem to break fedpkg upload, but I will have to wait until I have another large archive to upload to be sure that it fixes the problem.

I tried this when uploading the source archive for ruff, which is about 7–8MB. The upload was not especially fast, but it was network-bound with fedpkg using less than 10% of a core, which I took as a sign that this is working pretty well.

Thanks, @music, for the PR and analysis. I will check & review.

Commit 0e33baa5 fixes this pull-request

Pull-Request has been merged by onosek

Metadata