#25 Fix tests and turn off UTF8ENCODE fix
Closed by bcl. Opened by bcl.
bcl/rpmfluff master-rpm-strings  into  master

Download 25.patch

The fix does not work with rpm-4.14.2.1-7 which just appeared in rawhide, so disable it until this gets sorted out.
Also fixed some test warnings that made it hard to read the results, and reverted the NVR test's byte arrays back to strings.
Add a Requires for the newer version of rpm to avoid confusion.

1 new commit added

  • Cleanup some pylint warnings

Comited 3 patches which are fixing pylint issues, pdb leftover, opened files and assert straight away. Thank you!

I have been looking into rest of the patches and I'm not getting why these are needed?

Could you please also try with this commit - if it changes something?:

https://pagure.io/rpmfluff/c/3148594b69614f00c0d266f886be84add1ba0fa8?branch=master

Thank you in advance,
Jan

Just for a reference, this is related to https://bugzilla.redhat.com/show_bug.cgi?id=1700454

I have been looking into rest of the patches and I'm not getting why these are needed?
Could you please also try with this commit - if it changes something?:
https://pagure.io/rpmfluff/c/3148594b69614f00c0d266f886be84add1ba0fa8?branch=master

Ah, good! That fixes it for me, so the patch setting it to False can be dropped.

The other patches fix warnings from pylint.

Pull-Request has been closed by bcl

Metadata