#5 fence_sanlock/Makefile does not respect LDFLAGS
Opened 3 years ago by mschiff. Modified a year ago

When building fence_sanlock, user supplied LDFLAGS are ignored unlike for all other binaries in this repo.

This is a suggested patch:

--- sanlock-3.8.2.orig/fence_sanlock/Makefile   2020-08-21 19:48:12.695801870 +0200
+++ sanlock-3.8.2/fence_sanlock/Makefile        2020-08-21 19:47:50.477402437 +0200
@@ -34,7 +34,7 @@
 CFLAGS += -DVERSION=\"$(VER)\" -I../src -I../wdmd
 CFLAGS += -fPIE -DPIE

-LDFLAGS = -Wl,-z,now -Wl,-z,relro -pie
+LDFLAGS += -Wl,-z,now -Wl,-z,relro -pie
 LDADD = -lrt -laio -lblkid -lsanlock -lwdmd

 all: $(TARGET1) $(TARGET2)

Thanks, patch looks good.

Metadata Update from @nsoffer:
- Issue assigned to teigland

3 years ago

fence_sanlock is dead and I'll remove it. It was never actually used by anyone. The rpm has not built or installed this since rhel7.

Login to comment on this ticket.

Metadata