skt

#2 Add first test case on publisher base class
Closed by nkondras. Opened by agustinhenze.
agustinhenze/skt first-test-case  into  master

Download 2.patch

Hi, I added the first test case with the aim to serve as skeleton for the rest of test cases. I'd like to know what do you think to see if we are on the same line and in that case keep adding more test cases.

This looks good, thank you, Augustin! Would you be available for adding more test cases?

Hi @nkondras, of course I can add more test cases. However I'd like to add them in another PR to keep it simple. So if you wan to merge this, please go ahead.

Sure. Thank you, Augustin. We need those tests. Do you mind squashing these three commits into one, though? Otherwise this is a little too fine-grained. Meanwhile we'll try to figure out how to have CI for this repo, so that we can run the tests automatically.

Having CI would be great! Ok, I can squash them but I want to tell you anyway that I like to have small and simple atomic commits :).

rebased onto e128bd397b73021c8f139e9d192030a66ddf9356

rebased onto df2c159592cd8b7c0bb4546539e8557253527d87

We've got to balance the size of commits vs review time and history length, but otherwise I agree, logically-independent, atomic commits are the best. Rebased and merged in 55a06aa. I only modified the subject to start with a verb in imperative mood, as is customary, and to better match the content. Thank you!

Pull-Request has been closed by nkondras
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.