standard-test-roles

#281 Pulling out logs fails with "'remote_artifacts' is undefined"
Closed: Fixed Opened by ttomecek.

Closed: Fixed
Reopen Issue 
TASK [str-common-final : Pull out the logs from test environment to test runner] ***
fatal: [/workDir/workspace/fedora-rawhide-pr-pipeline/images/test_subject.qcow2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'remote_artifacts' is undefined\n\nThe error appears to have been in '/usr/share/ansible/roles/str-common-final/tasks/main.yml': line 3, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Pull out the logs from test environment to test runner\n  ^ here\n"}
    to retry, use: --limit @/workDir/workspace/fedora-rawhide-pr-pipeline/python-docker/tests/tests.retry

https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-rawhide-pr-pipeline/detail/fedora-rawhide-pr-pipeline/496/pipeline/

https://src.fedoraproject.org/rpms/python-docker/pull-request/7

@ttomecek hi.
I am not sure this is STR issue.

1.
This is tests.yml implementation issue.
please read about : https://docs.ansible.com/ansible/2.4/playbooks_reuse_includes.html
We use everywhere: include_role

Please try to switch to include_role too.

2.
https://src.fedoraproject.org/fork/ttomecek/rpms/python-docker/blob/testing-pr/f/tests/tests.yml uses a quite different approaching in using STR.

It includes a role in a task.

There is a working example : https://src.fedoraproject.org/rpms/file/blob/master/f/tests/tests.yml

Does it pass it for you locally?

Thanks, that indeed helped. I always confuse import_ and include_.

Would it make sense to document this?

Tomas hi!

Sure, you can send a PR. If not I will add it by my own.

Please close this issue.

Thank you! Regards

On Fri, Nov 16, 2018 at 11:08 AM Tomas Tomecek pagure@pagure.io wrote:

ttomecek added a new comment to an issue you are following:
``
Thanks, that indeed helped. I always confuse import_ and include_.

Would it make sense to document this?
``

To reply, visit the link below or just reply to this email
https://pagure.io/standard-test-roles/issue/281

Metadata Update from @ttomecek:
- Issue close_status updated to: SOLVED
- Issue status updated to: Closed (was: Open)

Commit b9404e47 fixes this issue

@astepano Hi.

I am not sure this is STR issue.
1.
This is tests.yml implementation issue.
please read about : https://docs.ansible.com/ansible/2.4/playbooks_reuse_includes.html
We use everywhere: include_role
Please try to switch to include_role too.
...
There is a working example : https://src.fedoraproject.org/rpms/file/blob/master/f/tests/tests.yml

This working example uses roles:. roles should be equivalent to import_role. I am curious why import_role does not work?
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.