standard-test-roles

#60 executing testcases by make
Closed: SOLVED Opened by mkolar.

Closed: SOLVED
Reopen Issue

Some beakerlib testcases contain part of testing logic in Makefile.

The current test driver execute testcases directly by sh /patch/to/runtest.sh command which can cause problems.

In quick start guide is mentioned, that testcases are executed by make run. [1]
Also Beaker documentation describes metadata of Makefile which must be defined in each Beaker task. [2]

I recommend modify current test driver so that testcases are executed by make for avoid problems.

references:
[1] https://beaker-project.org/psss-beaker-quick-start-guide-slides.pdf
[2] https://beaker-project.org/docs/user-guide/task-metadata.html

I recommend modify current test driver so that testcases are executed by make for avoid problems.

The command 'make' is not available on Atomic Host or in containers. In theory it is possible to place it there ... but we must be very careful how much we change the system under test ... before it no longer matches what a user or customer would see.

I double checked the 'make' command is available in Atomic Host. ... I guess we should use it when available. The rest of the comment still stands though.

@mkolar implemented in
https://pagure.io/standard-test-roles/blob/master/f/roles/standard-test-beakerlib/tasks/main.yml#_88

Hi.

I looked at : https://pagure.io/standard-test-roles/blob/master/f/roles/standard-test-beakerlib/tasks/main.yml

What is implemented? Could you please send a PR?

We already call make, as well as ./runtest.sh

Check it:

https://pagure.io/standard-test-roles/blob/master/f/roles/standard-test-beakerlib/tasks/main.yml#_86

I agree that we need to change priority: first call make if there is Makefile, than call runtest.sh if Makefile is absent.

Fixed in #156

Metadata Update from @astepano:
- Issue close_status updated to: SOLVED
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.