#115 wip: new role to blackbox-test container images
Closed by ttomecek. Opened by ttomecek.
ttomecek/standard-test-roles fix-110  into  master

Download 115.patch

Commit with test data is there so that you can understand the use case. There is still some work to be done, I'm looking for feedback here.

I will squash the commits once the change is done.

TODO:

  • [ ] support executing the test suite locally
  • [x] support executing the test suite in a fresh VM
  • [ ] add support for executing in CentOS
  • [ ] add support for executing in RHEL
  • [ ] provision the VM within the role (making it a fixture; suggested by @stefw)

1 new commit added

  • bump

Hi,
my PR
https://pagure.io/standard-test-roles/pull-request/97
tries to discuss and solve same issue. how to deal with test subject.
Probably it could be merged together

I see two different logical changes:
1. Change of inventory/standard-inventory-qcow2
2. Introducing of a new role.

Therefore, please send two independent PR.

This PR has 4 commit. This is not big PR. All 4 commit will be in git history. Is it wise to have 4 commits in git history for such small PR?

For a new role I would ask you provide a justification and purpose. What motivation was for creating this role? Why basic role cannot be used? For me it seems very simple role that can be shipped with tests. How many tests will use this role?

See the description: this PR is far from being finished. I'll make it more obvious by adding wip in the title.

I already talked to Stef and he suggested to utilize the merge script and let the role provision the VM and make it a fixture, thus not utilize the dynamic inventory script.

Andrei, I agree that the basic role is a better fit, thus closing this.

Pull-Request has been closed by ttomecek

Metadata