PR#333: standard-test-source: install rpm-build only as root -

standard-test-roles

#333 standard-test-source: install rpm-build only as root

Closed May 10, 2019 by mvadkert. Opened Apr 16, 2019 by mvadkert.

mvadkert/standard-test-roles rfe-rpm-build-only-root into master

mvadkert commented Apr 16, 2019

Without this patch, people running STR against a remote machine
without root cannot use this role ...

Signed-off-by: Miroslav Vadkerti mvadkert@redhat.com

astepano commented Apr 16, 2019

https://docs.fedoraproject.org/en-US/ci/standard-test-interface/#_invocation

4. MUST execute the playbook as root.

If you want this change, then we need change STI.
Sorry. It is not about me. It is about standard.

mvadkert commented Apr 16, 2019

@dperpeet @bookwar kindly asking for help here :) seems we are going against our users here.

@dhowells uses standard-test-source role and wants to use 1minutetip to execute the test suite from his localhost as non-root (tests run remotely on a VM). This worked before (see fix for the same problem here: https://pagure.io/standard-test-roles/c/df015d247fb79ca0252c982ecc4c4b0ad44dae41?branch=master). With reimplementation of standard-test-source role this regressed and user cannot use this role if he is not root. Can you provide an ack for @astepano so we can fix this small change so 1minutetip workflow again works pls?

rebased onto b4145594e501ed5cf2c89d3bc626426288e7d14e

Apr 16, 2019

astepano commented Apr 16, 2019

@bgoncalv volunteered to rewrite STR to run rpm-build on test-env. It will be the best solution

dhowells commented Apr 16, 2019

This change works for me.

Tested-by: David Howells dhowells@redhat.com

bgoncalv commented Apr 17, 2019

My change will no drop the requirement of rpm-build on test system. rpm-build will continue to be needed as to run rpm -q --specfile... rpm-build is needed. Unless you know any other way to get this info.

I'm okay with @mvadkert change, I think the main reason for STI to require to run the playbook as root is due to dynamic inventory. But there are use cases where the inventory is already provisioned.
Maybe the role could check if rpm-build is already installed and if it is don't try to this task (but I don't know the best way to do it).

Other solution would add rpm-build as STR dep on spec file.

astepano commented Apr 23, 2019

@bgoncalv @mvadkert it seems we agreed to merge it with adding a banner, that easy to spot to git-commit or code itself.

mvadkert commented Apr 23, 2019

Agreed, I am preparing the PR

rebased onto 5a6f4be19963f9ad823eff7196c0abfc11be627f

Apr 26, 2019

mvadkert commented Apr 26, 2019

I added code to handle better the error when run without root and rpm-build is not installed

rebased onto fea88d1bbe81987ae97322b538b325949f57f349

Apr 26, 2019

mvadkert commented Apr 26, 2019