#37 Revert "roles: Clear the remote_artifacts directory before use"
Merged by stefw. Opened by merlinm.
Unknown source master

Download 37.patch

This reverts commit 43ce1143e78d4f1abd242c9ca692354ceba7baa6.

It turns out PR#27 (which merged the above mentioned commit) causes results to be dropped from the summary in the primary test.log artifact when the test playbook applies more than one role.

It is the responsibility of the user to clean the remote_artifacts and local artifacts directories when re-running tests on a target.

See https://upstreamfirst.fedorainfracloud.org/bash/pull-request/2 for discussion of this problem, and https://upstreamfirst.fedorainfracloud.org/bash/blob/master/f/tests.yml for an example that demonstrates the problem when run with the classic tag.

Looks good to me.

I think in the future we could use temp files a better ansible script to avoid these problems. But until then this unbreaks broken tests.

Pull-Request has been merged by stefw

Metadata