#395 standard-test-basic and standard-test-beakerlib set default test case timeout to 4hrs
Merged 3 years ago by astepano. Opened 3 years ago by bgoncalv.
bgoncalv/standard-test-roles fix-source-role  into  master

@@ -22,7 +22,7 @@ 

  

   * **dir**: test directory. default: is the test name

   * **run**: command to run the test. default: ./runtest.sh

-  * **timeout**: abort test case after this time. More details on [timeout][1]. default: 0

+  * **timeout**: abort test case after this time. More details on [timeout][1]. default: 4h

   * **save_files**: List of extra files to save to artifacts.

     Path to the file is relative to test directory. The files are saved to

     artifacts under test name directory. default: None

@@ -21,7 +21,7 @@ 

                             item[(item.keys()|list)[0]]['dir']|default((item.keys()|list)[0]) }}" \

                  --artifactsdir "{{ remote_artifacts }}" \

                  --test "{{ item if item.keys is not defined else (item.keys()|list)[0] }}" \

-                 --timeout "{{ '0' if item.keys is not defined else

+                 --timeout "{{ '4h' if item.keys is not defined else

                             item[(item.keys()|list)[0]]['timeout']|default('0') }}" \

                  --cmd "{{ './runtest.sh' if item.keys is not defined else

                         item[(item.keys()|list)[0]]['run']|default('./runtest.sh') | regex_replace('\\', '\\\\') |

@@ -26,7 +26,7 @@ 

  

  ## Test case parameters

  

-  * **timeout**: abort test case after this time. More details on [timeout][2]. default: 0

+  * **timeout**: abort test case after this time. More details on [timeout][2]. default: 4h

  

  Example usage:

  

@@ -56,7 +56,7 @@ 

      script: run-beakerlib-test --workdir {{ tenv_workdir }} \

                      --artifactsdir {{ remote_artifacts }} \

                      --test "{{ item if item.keys is not defined else (item.keys()|list)[0] }}" \

-                     --timeout "{{ '0' if item.keys is not defined else

+                     --timeout "{{ '4h' if item.keys is not defined else

                                 item[(item.keys()|list)[0]]['timeout']|default('0') }}"

      with_items:

      - "{{ tests }}"

setting the default to 4hrs to be compatible with old pipeline implementation that limited playbook execution to 4hrs, so this should not cause any regression to existing playbooks.

fix: https://pagure.io/standard-test-roles/issue/394

1 new commit added

  • standard-test-beakerlib set default test case timeout to 4hrs
3 years ago

Looks, good, please squash 2 commits in 1 and please put 1 comment into git-commit info. Thank you!

rebased onto b05fc8c

3 years ago

rebased onto 8b43e20

3 years ago

Thank you, let's merge when I fix CI checking. (need a few days.)

rebased onto 5a2bc61

3 years ago

pretty please pagure-ci rebuild

Commit 314d1e6 fixes this pull-request

Pull-Request has been merged by astepano

3 years ago

Pull-Request has been merged by astepano

3 years ago