#403 add support for TEST_EXTRA_SSH_ARGS
Merged by astepano. Opened by rmeggins.
rmeggins/standard-test-roles extra-ssh-args  into  master

Download 403.patch

https://pagure.io/standard-test-roles/issue/400
User can pass in extra SSH arguments to workaround the
issue.

I have confirmed that this allows me to test with EL6 images

@nhosoi @spetros

@jjelen

Technically, this is fine. But here I would like to see some other example. I hope you are not using DSA keys anywhere in production. Something like PubkeyAcceptedKeyTypes=+ssh-rsa should do the same job, as I assume the issue is that the EL6 does not support RSA with SHA2 extensions and RSA with SHA1 is no longer allowed in recent Fedora and EL9.

rebased onto 4a8b8f47584e2d19e9cf09f3dd945d5e015de467

Thanks @jjelen - I have confirmed that ssh-rsa works with EL6.

would not it make sense to pass here just the opts as opts.host is obviously part of the opts? (unless this is part of some API).

Ack to merge, looks reasonable.
Please write comment when the PR is ready to be merged.

would not it make sense to pass here just the opts as opts.host is obviously part of the opts? (unless this is part of some API).

@jjelen inv_host is called from inv_list with the image to use as the first argument

would not it make sense to pass here just the opts as opts.host is obviously part of the opts? (unless this is part of some API).

@jjelen inv_host is called from inv_list with the image to use as the first argument

OK, fine for me.

the PR is ready to be merged

Commit d01971e6 fixes this pull-request

Pull-Request has been merged by astepano

Pull-Request has been merged by astepano

Metadata