#238 Run abicheck on everything (except the blacklist), not just critpath
Closed: Fixed 7 years ago Opened 7 years ago by ralph.

This is coming from the discussion in greenwave#68.

We can now (possibly) gate things on dist.abicheck runs.

  • Do we want to? If not, tell me and we can just drop this.

If we do, then greenwave would currently need to learn about critpath to only gate critpath packages on dist.abicheck. This is because abicheck is only run on critpath packages. We can of change this and teach greenwave about critpath.. but would it be simpler to just start running abicheck on everything? @kparal seemed to suggest that this would be fine.

Tell me. :) Should we run critpath on everything? Or teach greenwave to only require abicheck for critpath packages?


@lbrabec is looking at the dev results and trying to identify packages which should go into the abicheck blacklist

Metadata Update from @kparal:
- Issue assigned to lbrabec

7 years ago

Table below shows packages with at least 3 crashes in execdb since 2017-06-28 to 2017-10-26. For each package I checked resultsdb for results (runs of abicheck with no crash) and computed crash rate.

package        crashes    results  crash rate %
ceph                 3         12          20
community-m          5          4          56
COPASI               6         18          25
cross-binut          3          0         100
dovecot              6         10          38
freecad              4          1          80
freeorion            3          9          25
icecat               6          3          67
k3d                  3          6          33
kdevelop-ph          5          0         100
krita                6          4          60
link-gramma          3          6          33
moarvm               3          2          60
os-autoinst         12          2          86
perl-Verilo          5          1          83
polymake             5          4          56
python-qt5           4          5          44
qemu                10         15          40
qt-creator          13          1          93
qt5-qtbase           6         13          32
root                12          3          80
seamonkey            3          4          43
slic3r-prus          4          0         100
webkitgtk4           8         11          42
wine                16         10          62

crashrate2.png

Awesome, thanks Lukas. The only packages that have 100% crash rate also have a low run count, so we can't fully rely on that. It's a bit worrying we have so many packages crashing intermittently (it seems we'll need the "re-run task" functionality soon).

I think we could enable abicheck on all packages in production without further delays, thoughts? If we hit abicheck crashes on certain packages, we'll consult this table to see whether it's a long time offender and blacklist it or not.

If this is to work decently, greenwave will need to support user waiving, we'll need to support task rescheduling, and we'll need to start sharing the blacklist between trigger playbook and greenwave playbook. But those are different tickets.

Metadata Update from @kparal:
- Issue assigned to kparal (was: lbrabec)

7 years ago

greenwave will need to support user waiving

Yes. Lots of the pieces are there, but the whole UX isn't nice (they have to submit an HTTP POST by hand! Unacceptable.) We'll have a waiverdb-cli to waive first, follow by a button in Bodhi.

Deployed to prod. Abicheck should now be run on everything (except blacklist).

Metadata Update from @kparal:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
- Issue tagged with: infra

7 years ago

Log in to comment on this ticket.

Metadata
Attachments 1
Attached 7 years ago View Comment