PR#255: Revert "CI/CD: Install build dependencies at runtime" -

waiverdb

#255 Revert "CI/CD: Install build dependencies at runtime"

Merged Oct 31, 2018 by lholecek. Opened Oct 31, 2018 by rayson.

rayson/waiverdb cicd-revert-253 into master

rayson commented Oct 31, 2018

This reverts commit 225cd5ec2edc7683d377712b2e577eaa4a006e9c.

I did try running sudo on OpenShift and found it worked (maybe I logged into another cluster with looser policies applied?). But on UpShift Prod it is not allowed to run setuid programs (including sudo). So please revert this change.

Dependencies rarely change. We could introduce some manual operations to deal with that before there is a real solution.
So let's just rebuild the Jenkins slave image with new dependencies.

rayson commented Oct 31, 2018

I've rebuilt docker-registry.engineering.redhat.com/factory2/waiverdb-jenkins-slave:latest with new dependencies introduced by #254 by running against UpShift Prod waiverdb-test project:

oc start-build waiverdb-dev-jenkins-slave --commit=refs/pull/254/head

lholecek commented Oct 31, 2018

+1 Thanks.

Pull-Request has been merged by lholecek

Oct 31, 2018

Metadata

Assignee

None

Tags

No Tags

waiverdb

#255 Revert "CI/CD: Install build dependencies at runtime" Merged Oct 31, 2018 by lholecek. Opened Oct 31, 2018 by rayson. rayson/waiverdb cicd-revert-253 into master

Metadata

#255 Revert "CI/CD: Install build dependencies at runtime"

Merged Oct 31, 2018 by lholecek. Opened Oct 31, 2018 by rayson.

rayson/waiverdb cicd-revert-253 into master