#27 clean up the code to make flake8 happy
Merged by mjia. Opened by mjia.
mjia/waiverdb cleanup_flake8  into  master

Download 27.patch
no initial comment

This is better as it is now. The reason for the trailing comma, and closing parenthesis on a separate line, is to make the diff nicer when you add or remove entries in the dict. Can you just figure out whichever flake8 error code this is, and turn it off instead?

I guess these errors are good to report on normal code -- the issue is just in that conf.py which is really config and not code. Does flake8 have a way we can ignore these errors just in that file?

Ugh I am surprised this is required by PEP8... a good example of where PEP8 is just wrong I think. Oh well...

There is no way to disable these errors in a specific file. I guess we can exclude it instead.

rebased

Yeah excluding conf.py from flake8 entirely seems reasonable.

I guess another option would be to just exclude setup.py as well, because it is kind of a special case like conf.py. But this is okay too I think.

Pull-Request has been merged by mjia

Using format would solve the problem and looks much cleaner than either of these options.

@jcline that's a good point. It's my fault for being stuck in my old-school ways with %-formatting. :-)

Metadata