Add message schema according to doc: https://fedora-messaging.readthedocs.io/en/latest/messages.html
JIRA: RHELWF-4966
License file is already in COPYING file.
COPYING
Also, the .gitignore in sub-directory seems misplaced.
.gitignore
Can we use just # SPDX-License-Identifier: GPL-2.0+ instead of the long copyright preambles in files?
# SPDX-License-Identifier: GPL-2.0+
License file is already in COPYING file. Also, the .gitignore in sub-directory seems misplaced.
The skeleton is auto-generated by CookieCutter. I am not sure, do you mean to merge .gitignore in the parent folder? And for the License file, I am not sure, is it ok to create a new package for the message schema without LICENSE file?
Are they the same thing? Do we need to mention REDHAT Copyright?
Can we use just # SPDX-License-Identifier: GPL-2.0+ instead of the long copyright preambles in files? Are they the same thing? Do we need to mention REDHAT Copyright?
Not sure, but we use it already in other files.
I tried to use include and global-include in the MANIFEST.in file to include the parent folder's COPYING file, but it doesn't look good, I am assuming the syntax is for the source tree in this project folder, not the parent folder.
For the .gitignore file, ack and fixed
rebased onto 412425a059115c41099fdb56e615063e5779d1b4
Scenario field is missing:
"scenario": {"type": ["string", "null"]},
Subject is not string, also it is deprecated - maybe we can leave it out. New fields are subject_type and subject_identifier (non-nullable strings).
Full example:
{ "comment": "This is fine", "id": 200836, "product_version": "fedora-11", "proxied_by": null, "scenario": null, "subject": { "item": "nethack-prod-3.5.202204250832.qqh5t", "type": "component-version" }, "subject_identifier": "nethack-prod-3.5.202204250832.qqh5t", "subject_type": "component-version", "testcase": "greenwave-segment-tests.fake.testcase.tier0.validation", "timestamp": "2022-04-25T08:34:24.421402", "username": "HTTP/greenwave-test.apps.ocp4.prod.psi.redhat.com", "waived": true }
BTW, real-world messages can be found at: https://apps.fedoraproject.org/datagrepper/raw?topic=org.fedoraproject.prod.waiverdb.waiver.new&delta=10000
Ack. Fixing
rebased onto 2c4711db04b73eaa5815a29474dd5bb5a144366d
Ack. Updated
LGTM. :thumbsup:
Looks I can't merge this patch. Lukas, can you help to merge it, or maybe I need some permission?
rebased onto 8c53d5768d276bc51edf9dd0ef34e8290907c535
Pull-Request has been merged by lholecek
Add message schema according to doc:
https://fedora-messaging.readthedocs.io/en/latest/messages.html
JIRA: RHELWF-4966