#43 Dockerfile: set some labels
Merged by dcallagh. Opened by dcallagh.
dcallagh/waiverdb docker-labels  into  master

Download 43.patch

The CentOS base image already sets "name", "vendor", "license", and
"build-date" labels so we should explicitly overwrite them in our
Dockerfile. Otherwise we inherit the CentOS labels, and our container
will show up in OpenShift as being CentOS instead of WaiverDB.

Perhaps "Red Hat" or "Factory 2.0" here?

:+1: from me. I'm neutral on @mprahl's suggestion. Any of those options (waiverdb devs, factory 2, RH, or whoever) works for me.

On the other hand, say "Red Hat" might be a little heavy-handed -- it might appear as if it were a supported Red hat product, which it is not. It is an upstream project.

RIght... I am not too sure about the exact semantics of the "vendor" label (there appears to be no spec or anything, I think CentOS just made it up). But I don't want to imply that Red Hat or anyone else is selling you this container.

In the end it doesn't really matter what we have here, I just wanted it not to say vendor is CentOS since that is clearly wrong. :-)

RIght... I am not too sure about the exact semantics of the "vendor" label (there appears to be no spec or anything, I think CentOS just made it up). But I don't want to imply that Red Hat or anyone else is selling you this container.

In the end it doesn't really matter what we have here, I just wanted it not to say vendor is CentOS since that is clearly wrong. :-)

:thumbsup:

Pull-Request has been merged by dcallagh

Metadata