workstation-ostree-config

#421 comps-sync.py: Refactor to simplify maintenance
Merged by siosm. Opened by siosm.
Unknown source main

Download 421.patch

comps-sync f40 2023-09-26

comps-sync.py: Factor package manifest loading code

comps-sync.py: Pass regexp exclude list to is_exclude_listed

comps-sync.py: Factor load_packages_from_comps_group

comps-sync.py: Unify group loading logic

comps-sync.py: Remove special case for kernel packages

comps-sync.py: Factor manifest/comps lists comparison

Also improve the format of the package diff.

comps-sync.py: Use new functions for desktop specific manifests

comps-sync.py: Clarify the groups we get packages from

comps-sync.py: Factor the manifest update

comps-sync.py: Move code under main function

comps-sync-exclude-list.yml: Update comments

comps-sync-exclude-list.yml: Remove obsolete excludes

fedora-common-ostree: Document nss-altfiles inclusion

This should let us do https://gitlab.com/fedora/ostree/sig/-/issues/5 more easily

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/6b84477091474c778816802d6719bd67

It's a lot of change and I might be missing something, but on the whole I like it. Are the changes in the final 'comps-sync' commit expected and correct?

Yes. I had initially made the sync before to start from a clean state but I've retried it and I have the same results:

$ ./comps-sync.py --save fedora-comps/comps-f40.xml.in
Syncing common packages:        +0, -0
Syncing packages for gnome:     +0, -0
Syncing packages for kde:       +1, -0
  + orca (default, groups: kde-desktop, arches: all)
Wrote kde-desktop-pkgs.yaml
Syncing packages for xfce:      +0, -0
Syncing packages for lxqt:      +0, -0
Syncing packages for deepin:    +0, -0
Syncing packages for mate:      +0, -0
Syncing packages for sway:      +0, -0
Syncing packages for cinnamon:  +1, -0
  + totem-video-thumbnailer (mandatory, groups: cinnamon-desktop, arches: all)
Wrote cinnamon-desktop-pkgs.yaml
Syncing packages for budgie:    +0, -0

I've been testing this change by replacing random packages in the manifests with foo and making sure the update looks good.

Pull-Request has been merged by siosm
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.