From 1a5ab4d88ece8ea061f545010decb95afc21c55e Mon Sep 17 00:00:00 2001 From: Jan Kaluža Date: Oct 20 2023 09:15:23 +0000 Subject: Do not run mock with `--postinstall`. With the `--postinstall` option, mock tries to install the built RPMs. This is not aligned with a way how RPMs are built in Koji - the `--postinstall` is not used there. It therefore means that for some components containing packages which cannot be installed (for whatever reason), the mock-build fails while Koji scratch-build works. This is confusing to users. In this commit, the `--postinstall` option is removed. The mock-build should focus on building the RPMs, testing whether they can be installed should be done as separate test. --- diff --git a/roles/mock-build/tasks/main.yaml b/roles/mock-build/tasks/main.yaml index 4c8aa3e..eb65093 100644 --- a/roles/mock-build/tasks/main.yaml +++ b/roles/mock-build/tasks/main.yaml @@ -32,7 +32,7 @@ shell: > mock {{ mock_opts }} {{ artifacts_baseurls|trim }} {{ repos_baseurls|trim }} --localrepo {{ localrepo_dir }} - --postinstall --chain {{ srpm }} + --chain {{ srpm }} - name: Sync chained repo in {{ output_repo_dir }} command: >