freshmaker

#112 Removed blacklist from freshmaker
Merged by jkaluza. Opened by mcurlej.
mcurlej/freshmaker issue107  into  master

Download 112.patch

Hi All,

issue: https://pagure.io/freshmaker/issue/107

so after discussion with @jkaluza we come to an agreement that to have a blacklist and a whitelist in configuration is not such a good idea. So i removed the blacklist option from the config and refactored the allow_build method. Now if you want your artifact to be build you need it whitelisted. Also allow_build method now raises an UnprocessableEntity error when the provided regex in whitelist is not a valid regex. So WDYT?

Signed-off-by: Martin Curlej mcurlej@redhat.com

Sounds good to me.

For now, we need a whitelist so we can slowly increase the set of containers being handled.

At some point, it will be easier to maintain a blacklist -- i.e., when we handle all containers except foo and bar, because they're screwy.

Anyways - :+1: from me. Would be interested to hear from @jkaluza too.

Looks good, +1

@mcurlej, can you rebase and merge? (Do you have rights?)

rebased onto b98fc8ffdcbf17aa92d2c75fa137e2243b5ec6d8

@jkaluza @ralph
Sorry for the delay, bodhi was taking most of my time. Rebased.

@mcurlej: There seems to be one failed test related to the blacklist/whitelist change, could you check it? https://jenkins.fedorainfracloud.org/job/freshmaker/393/console

@jkaluza wrt to the tests which is failing, the test checks if a module is build if its on a blacklist. Its failing because its testing a feature i am removing with this PR.

Cool - go for removing the test, then. :)

rebased onto 9e2264c8eb66b3e1695e28f46da8222a3ebceea5

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.