Pull requests - freshmaker

freshmaker

Pull Requests
0 Open 469 Merged Closed

#535 Fix the documentation: wrong api endpoint

master 0

Merged Jun 15, 2020. Opened Jun 15, 2020 by gnaponie.

#534 Add async build API documentation

master 0

Merged Jun 15, 2020. Opened Jun 11, 2020 by gnaponie.

#533 Install deps for rpm-py-installer

master 0

Merged Jun 10, 2020. Opened Jun 9, 2020 by lucarval.

#531 Get content_sets for all architectures

master 0

Merged Jun 9, 2020. Opened Jun 8, 2020 by gnaponie.

#530 Do not require system site packages for testing

master 0

Merged Jun 4, 2020. Opened Jun 2, 2020 by lucarval.

#529 Reduce memory usage of images to rebuild

master 0

Merged Jun 9, 2020. Opened May 25, 2020 by apaplaus.

#528 Fixing flake8 bug on `typing`

master 0

Merged May 21, 2020. Opened May 20, 2020 by gnaponie.

#527 Store the Freshmaker event in the Lightblue class

master 0

Merged May 25, 2020. Opened May 5, 2020 by mulaieva.

#526 No need to get unpublished images anymore

master 0

Merged May 5, 2020. Opened May 5, 2020 by gnaponie.

#525 Resolve exception when DB is disconnected

master 0

Merged May 5, 2020. Opened Apr 28, 2020 by apaplaus.

#524 Add mypy for testing

master 0

Merged May 6, 2020. Opened Apr 28, 2020 by mulaieva.

#523 Support querying events with requester names

master 0

Merged Apr 24, 2020. Opened Apr 24, 2020 by qwan.

#522 Bug fix: affected packages not correctly detected

master 0

Merged Apr 22, 2020. Opened Apr 20, 2020 by gnaponie.

#521 Populate some fields for manual rebuilds

master 0

Merged Apr 23, 2020. Opened Apr 17, 2020 by apaplaus.

#520 Record the lightblue queries

master 0

Merged Jun 15, 2020. Opened Apr 17, 2020 by mulaieva.

#519 Bug fix: Freshmaker was not always building modules

master 0

Merged Apr 15, 2020. Opened Apr 14, 2020 by gnaponie.

#518 Build container image without an RPM

master 0

Merged Apr 15, 2020. Opened Apr 8, 2020 by lucarval.

#517 Fix find_images_to_rebuild.py with no images

master 0

Merged Apr 7, 2020. Opened Apr 7, 2020 by lucarval.

#516 Perform non-CVE builds

master 0

Merged Jun 1, 2020. Opened Apr 6, 2020 by gnaponie.

#515 Removing usage of git archive to get 'container.yaml' and 'content_sets.yml' files

master 0

Merged Apr 21, 2020. Opened Apr 6, 2020 by apaplaus.

#514 Revert "Merge #506 `Trailing slash fix`"

master 0

Merged Apr 1, 2020. Opened Apr 1, 2020 by apaplaus.

#513 Delete empty kerberos class and function with their context

master 0

Merged Apr 6, 2020. Opened Apr 1, 2020 by apaplaus.

#512 Make resolve_commit not set published property

master 0

Merged Apr 8, 2020. Opened Mar 27, 2020 by cqi.

#511 Resolve problem with connecting to Pulp

master 0

Merged Apr 8, 2020. Opened Mar 26, 2020 by apaplaus.

#508 Remove unused code from lightblue.py

master 0

Merged Mar 26, 2020. Opened Mar 25, 2020 by lucarval.

#507 Replace image['brew']['build'] with image.nvr

master 0

Merged Mar 26, 2020. Opened Mar 25, 2020 by cqi.

#506 Trailing slash fix

master 0

Merged Mar 27, 2020. Opened Mar 24, 2020 by apaplaus.

#505 Add the script to test new freshmaker deployment

master 0

Merged Mar 23, 2020. Opened Mar 20, 2020 by mulaieva.

#504 Display event dependency in api/v2

master 0

Merged Mar 20, 2020. Opened Mar 19, 2020 by lucarval.

#503 Simplify use of ThreadPoolExecutor with Executor.map

master 0

Merged Mar 21, 2020. Opened Mar 16, 2020 by cqi.

#502 Try hard to find the repositories for an image

master 0

Merged May 20, 2020. Opened Mar 13, 2020 by lucarval.

#501 Aggregate multi-arch info in ContainerImage

master 0

Merged Mar 10, 2020. Opened Mar 10, 2020 by lucarval.

#500 Revert "Revert "No need to convert compose ids or verify 'done' state""

master 0

Merged Mar 9, 2020. Opened Mar 9, 2020 by gnaponie.

#499 Fix issues while handling base images and published content

master 0

Merged Mar 9, 2020. Opened Mar 9, 2020 by lucarval.

#498 Generate rebuilt_nvr just before submitting an image build

master 0

Merged Mar 24, 2020. Opened Mar 9, 2020 by cqi.

#497 Allow test ManualRebuildWithAdvisoryEvent with find_images_to_rebuild.py script.

master 0

Merged Mar 9, 2020. Opened Mar 9, 2020 by jkaluza.

#496 Reduce number of calls during while-loop in _check_images_to_rebuild

master 0

Merged Mar 9, 2020. Opened Mar 5, 2020 by cqi.

#495 Refactor find latest image by its build NV

master 0

Merged Mar 25, 2020. Opened Mar 5, 2020 by cqi.

#494 Run docker prune before building the image in the JJ

master 0

Merged Mar 4, 2020. Opened Mar 4, 2020 by gnaponie.

#492 Mock koji.read_config properly in tests

master 0

Merged Mar 9, 2020. Opened Mar 3, 2020 by cqi.

#491 Revert "No need to convert compose ids or verify 'done' state"

master 0

Merged Mar 2, 2020. Opened Mar 2, 2020 by gnaponie.

#489 Fix argument type in docstring

master 0

Merged Mar 2, 2020. Opened Mar 2, 2020 by cqi.

#488 Rename find_parent_image_from_child

master 0

Merged Feb 28, 2020. Opened Feb 28, 2020 by gnaponie.

#487 Fix some typos

master 0

Merged Feb 28, 2020. Opened Feb 28, 2020 by cqi.

#486 Use unittest.mock

master 0

Merged Feb 27, 2020. Opened Feb 27, 2020 by cqi.

#485 Cleanup LightBlue._make_request

master 0

Merged Feb 28, 2020. Opened Feb 27, 2020 by cqi.

#484 Rename include_rpms to include_rpm_manifest

master 0

Merged Feb 27, 2020. Opened Feb 27, 2020 by cqi.

#483 Override parent image

master 0

Merged Feb 27, 2020. Opened Feb 26, 2020 by gnaponie.

#482 Add missing fedmsg.d directory.

master 0

Merged Feb 26, 2020. Opened Feb 26, 2020 by jkaluza.

#481 Do not run find_images_to_rebuild 10 times.

master 0

Merged Feb 26, 2020. Opened Feb 26, 2020 by jkaluza.

#480 Ensure file descriptors are closed in get_distgit_files

master 0

Merged Feb 27, 2020. Opened Feb 21, 2020 by cqi.

#479 Remove unused methods related to repo operations

master 0

Merged Feb 27, 2020. Opened Feb 21, 2020 by cqi.

#478 Add missing variable definition in load_cg_metadata

master 0

Merged Feb 27, 2020. Opened Feb 21, 2020 by cqi.

#477 Some minor fixes

master 0

Merged Feb 20, 2020. Opened Feb 20, 2020 by cqi.

#476 Don't limit images research to published images

master 0

Merged Feb 14, 2020. Opened Feb 14, 2020 by gnaponie.

#475 Filter out images based on the content_set

master 0

Merged Feb 18, 2020. Opened Feb 13, 2020 by gnaponie.

#474 Add async build view

master 0

Merged Feb 18, 2020. Opened Feb 13, 2020 by qwan.

#472 No need to use layers to find parent image

master 0

Merged Feb 10, 2020. Opened Feb 10, 2020 by gnaponie.

#471 Add async rebuild handler

master 0

Merged Feb 13, 2020. Opened Feb 10, 2020 by cqi.

#470 Fix handle of further works

master 0

Merged Feb 10, 2020. Opened Feb 7, 2020 by cqi.

#469 Set FRESHMAKER_TESTING_ENV in testing env

master 0

Merged Feb 7, 2020. Opened Feb 7, 2020 by qwan.

#467 Fix tox, take 3

master 0

Merged Feb 6, 2020. Opened Feb 6, 2020 by gnaponie.

#465 Fix tox

master 0

Merged Feb 4, 2020. Opened Feb 4, 2020 by gnaponie.

#464 Install missing python3-rpm package

master 0

Merged Feb 3, 2020. Opened Feb 3, 2020 by gnaponie.

#462 Fix pagination metadata to include query params and next/prev pages

master 0

Merged Jan 23, 2020. Opened Jan 20, 2020 by qwan.

#461 Remove redundant code

master 0

Merged Jan 15, 2020. Opened Jan 15, 2020 by qwan.

#460 No need to convert compose ids or verify 'done' state

master 0

Merged Jan 17, 2020. Opened Jan 15, 2020 by qwan.

#459 Remove usage of mutable default arguments

master 0

Merged Jan 13, 2020. Opened Jan 10, 2020 by qwan.

#458 Fix some docstrings describing parameters

master 0

Merged Jan 9, 2020. Opened Jan 3, 2020 by cqi.

#456 Use 'parent_brew_build' to find parent images

master 0

Merged Feb 3, 2020. Opened Dec 4, 2019 by gnaponie.

#455 Manager CLI doesn't depend on flask-script anymore

master 0

Merged Dec 5, 2019. Opened Dec 2, 2019 by cqi.

#454 Reraise the exception in the correct location in utils.py:retry

master 0

Merged Dec 2, 2019. Opened Nov 27, 2019 by mprahl.

#453 Allow inheriting the advisory ID from the dependent Freshmaker event

master 0

Merged Dec 2, 2019. Opened Nov 27, 2019 by mprahl.

#452 Fix the unit tests from an issue in PR #444

master 0

Merged Nov 28, 2019. Opened Nov 26, 2019 by mprahl.

#451 Mark parent images as directly affected when necessary

master 0

Merged Dec 1, 2019. Opened Nov 22, 2019 by mprahl.

#450 Refactor find_images_with_included_srpms to not return duplicate images

master 0

Merged Nov 26, 2019. Opened Nov 21, 2019 by mprahl.

#449 Rename filter_out_non_modular_container_images

master 0

Merged Nov 22, 2019. Opened Nov 21, 2019 by mprahl.

#448 Support running the find_images_to_rebuild.py script using a virtualenv

master 0

Merged Nov 22, 2019. Opened Nov 21, 2019 by mprahl.

#447 Rename filter_out_images_with_lower_srpm_nvr to filter_out_images_with_higher_srpm_nvr

master 0

Merged Nov 22, 2019. Opened Nov 20, 2019 by mprahl.

#446 Clarify a log message in _find_images_to_rebuild

master 0

Merged Nov 22, 2019. Opened Nov 20, 2019 by mprahl.

#445 Only get the RHEL release when rhel_release_prefix is set in Errata.get_builds

master 0

Merged Nov 25, 2019. Opened Nov 20, 2019 by mprahl.

#444 Set the default handlers and parsers

master 0

Merged Nov 25, 2019. Opened Nov 20, 2019 by mprahl.

#443 Configuration improvements

master 0

Merged Nov 14, 2019. Opened Nov 13, 2019 by gnaponie.

#442 Add a configuration to add an optional suffix to the release of the rebuilt NVR

master 0

Merged Nov 4, 2019. Opened Nov 1, 2019 by mprahl.

#441 Allow image rebuild for modules too

master 0

Merged Oct 25, 2019. Opened Oct 23, 2019 by gnaponie.

#440 Migrate to Rover groups and add the new role of "manual_rebuilder"

master 0

Merged Oct 23, 2019. Opened Oct 18, 2019 by mprahl.

#439 Use the newer internal container registry

master 0

Merged Oct 22, 2019. Opened Oct 18, 2019 by lucarval.

#438 Use internal conf for the SFM2 API

master 0

Merged Oct 10, 2019. Opened Oct 10, 2019 by gnaponie.

#437 Use SFM2 API to get the impact and affected components from CVE

master 0

Merged Oct 10, 2019. Opened Oct 8, 2019 by gnaponie.

#436 Upgrade to the new version also python3-kobo-rpmlib

master 0

Merged Oct 3, 2019. Opened Oct 3, 2019 by gnaponie.

#435 Avoid returning value conditionally

master 0

Merged Oct 2, 2019. Opened Oct 1, 2019 by lholecek.

#434 py2 to py3, handle byte strings

master 0

Merged Oct 1, 2019. Opened Oct 1, 2019 by gnaponie.

#433 Add find_images_to_rebuild.py script

master 0

Merged Sep 30, 2019. Opened Sep 30, 2019 by jkaluza.

#432 Upgrade kobo to 0.10.0 due to a bug

master 0

Merged Sep 26, 2019. Opened Sep 26, 2019 by gnaponie.

#431 Drop python2, use python3 for qpid and wsgi

master 0

Merged Sep 25, 2019. Opened Sep 25, 2019 by gnaponie.

#430 fedmsg entry point needs to be py3

master 0

Merged Sep 25, 2019. Opened Sep 25, 2019 by gnaponie.

#429 Drop python2... again

master 0

Merged Sep 24, 2019. Opened Sep 24, 2019 by gnaponie.

#428 Drop py2 support

master 0

Merged Sep 24, 2019. Opened Sep 19, 2019 by gnaponie.

#427 Downgrade to old version of qpid-proton to fix memory leak.

master 0

Merged Sep 18, 2019. Opened Sep 18, 2019 by jkaluza.

#426 Return both Koji build NVRs and SRPM NVRs in the `Errata.get_builds()`.

master 0

Merged Sep 3, 2019. Opened Sep 3, 2019 by jkaluza.

#425 Handle bugzilla whiteboard empty

master 0

Merged Sep 3, 2019. Opened Sep 2, 2019 by gnaponie.

#424 Add support for finding rpm brew builds included in a module

master 0

Merged Aug 29, 2019. Opened Aug 27, 2019 by yashn.

#423 Build RPM only for Fedora 29

master 0

Merged Aug 27, 2019. Opened Aug 27, 2019 by gnaponie.

#422 Jenkinsfile: build RPM for new versions of Fedora

master 0

Merged Aug 27, 2019. Opened Aug 27, 2019 by gnaponie.

#421 Filter out non-modular container images when handling modular RHSA

master 0

Merged Sep 2, 2019. Opened Aug 26, 2019 by gnaponie.

#420 Quiet down proton logs

master 0

Merged Aug 26, 2019. Opened Aug 26, 2019 by yashn.

#419 Correct wrong dependency

master 0

Merged Aug 22, 2019. Opened Aug 22, 2019 by gnaponie.

#418 Ensure arch_override is str type

master 0

Merged Aug 13, 2019. Opened Aug 12, 2019 by lucarval.

#417 Fix: Freshmaker gets unauthorized getting arch

master 0

Merged Aug 12, 2019. Opened Aug 12, 2019 by gnaponie.

#416 Add dev_scripts/find_images_to_rebuild.py and docs.

master 0

Merged Aug 7, 2019. Opened Aug 6, 2019 by jkaluza.

#415 Retry when fetching files from dist-git

master 0

Merged Aug 5, 2019. Opened Aug 2, 2019 by yashn.

#414 Describe the API v1 and v2 separately. Describe the messaging API.

master 0

Merged Aug 2, 2019. Opened Aug 2, 2019 by jkaluza.

#413 Remove unused and unmaintained parsers and handlers.

master 0

Merged Aug 1, 2019. Opened Aug 1, 2019 by jkaluza.

#409 Update ImageVerifier to match the current Lightblue code.

master 0

Merged Jul 30, 2019. Opened Jul 24, 2019 by jkaluza.

#408 Use the latest published release of parent image in most cases.

master 0

Merged Jul 30, 2019. Opened Jul 24, 2019 by jkaluza.

#407 Fix the switched `depending_events` and `depends_on_events` lists.

master 0

Merged Jul 19, 2019. Opened Jul 18, 2019 by jkaluza.

#406 Rebuild only affected pkgs by the CVE

master 0

Merged Jul 19, 2019. Opened Jul 18, 2019 by gnaponie.

#405 Add helper developer scripts

master 0

Merged Jul 29, 2019. Opened Jul 18, 2019 by jkaluza.

#404 Support querying events with state names

master 0

Merged Jul 24, 2019. Opened Jul 17, 2019 by qwan.

#403 Ignore container repos without auto_release_tags

master 0

Merged Jul 16, 2019. Opened Jul 15, 2019 by lucarval.

#402 Find out which pkgs in the advisory fix the CVE

master 0

Merged Jul 17, 2019. Opened Jul 15, 2019 by gnaponie.

#401 Guard against `IndexError`.

master 0

Merged Jul 11, 2019. Opened Jul 10, 2019 by ralph.

#400 Make a tiny query.

master 0

Merged Jul 11, 2019. Opened Jul 10, 2019 by ralph.

#399 Allow nesting BaseHandler exception handler decorators.

master 0

Merged Jul 11, 2019. Opened Jul 8, 2019 by jkaluza.

#398 Reuse "complete" ArtifactBuilds from original Event

master 0

Merged Jul 10, 2019. Opened Jul 8, 2019 by gnaponie.

#397 Get time_done data for events in CANCELED state

master 0

Merged Jul 8, 2019. Opened Jul 3, 2019 by srieger.

#396 Add option to show a shortened version of the JSON in the API to speed up loading times

master 0

Merged Jul 16, 2019. Opened Jul 1, 2019 by srieger.

#395 Add to the README some initial dev setup

master 0

Merged Jun 28, 2019. Opened Jun 28, 2019 by gnaponie.

#394 Group images to deduplicate also according to their repositories.

master 0

Merged Jun 28, 2019. Opened Jun 28, 2019 by jkaluza.

#393 Handle multiple SRPM NVRs with the same `name` in Lightblue class.

master 0

Merged Jun 28, 2019. Opened Jun 28, 2019 by jkaluza.

#392 Do not mark the event failed in-case of a service failure

master 0

Merged Jul 8, 2019. Opened Jun 27, 2019 by yashn.

#391 Fix the deduplication code when `conf.lightblue_released_dependencies_only = True`.

master 0

Merged Jun 27, 2019. Opened Jun 27, 2019 by jkaluza.

#390 Move RebuildImagesOnRPMAdvisoryChange tests to right file.

master 0

Merged Jun 27, 2019. Opened Jun 27, 2019 by jkaluza.

#389 Accept all possible `state` representation in `transition()` methods.

master 0

Merged Jun 27, 2019. Opened Jun 27, 2019 by jkaluza.

#388 Use right parent image if parent image changes during child image releases.

master 0

Merged Jun 26, 2019. Opened Jun 25, 2019 by jkaluza.

#387 Show event dependencies in the REST API

master 0

Merged Jun 25, 2019. Opened Jun 25, 2019 by gnaponie.

#386 Add support for manual dependent rebuilds on existing events

master 0

Merged Jun 25, 2019. Opened Jun 20, 2019 by yashn.

#385 Include Freshmaker event start and completion times in the REST API

master 0

Merged Jun 24, 2019. Opened Jun 18, 2019 by srieger.

#384 Do not mark Beta or Tech Preview images as "latest_released".

master 0

Merged May 31, 2019. Opened May 30, 2019 by jkaluza.

#382 Call this "Freshmaker ID" in the cli output.

master 0

Merged May 13, 2019. Opened May 1, 2019 by ralph.

#381 Fix wrong syntax when querying for release_categories.

master 0

Merged Apr 24, 2019. Opened Apr 24, 2019 by jkaluza.

#380 Add ArtifactBuild.rebuild_reason column.

master 0

Merged May 3, 2019. Opened Apr 23, 2019 by jkaluza.

#379 Rebuild also for tech preview and beta images

master 0

Merged Apr 23, 2019. Opened Apr 18, 2019 by ralph.

#378 Fix `HTTPError.response` comparison.

master 0

Merged Apr 11, 2019. Opened Apr 11, 2019 by jkaluza.

#377 Do not treat ODCSComposeNotReady as error which fails ArtifactBuild.

master 0

Merged Apr 11, 2019. Opened Apr 11, 2019 by jkaluza.

#376 Retry the `Errata._errata_authorized_get()` call.

master 0

Merged Apr 9, 2019. Opened Apr 9, 2019 by jkaluza.

#375 Fix compatibility with new Pulp version.

master 0

Merged Mar 25, 2019. Opened Mar 25, 2019 by jkaluza.

#374 Use f29 for Freshmaker image builds

master 0

Merged Mar 14, 2019. Opened Mar 13, 2019 by fivaldi.

#373 Fix Jenkins CI vol #2

master 0

Merged Mar 13, 2019. Opened Mar 12, 2019 by fivaldi.

#372 Rework Jenkins CI

master 0

Merged Mar 11, 2019. Opened Mar 11, 2019 by fivaldi.

#371 Support for event canceling

master 0

Merged Mar 13, 2019. Opened Mar 8, 2019 by fivaldi.

#370 Add new 'metadata' field in the manual rebuild API to store additional metadata for Event.

master 0

Merged Feb 27, 2019. Opened Feb 25, 2019 by jkaluza.

#369 Do not use Lightblue "deprecated" field. Use "release_categories" instead.

master 0

Merged Feb 22, 2019. Opened Feb 22, 2019 by jkaluza.

#368 Add new "/verify-image" and "/verify-image-repository" API endpoints.

master 0

Merged Feb 21, 2019. Opened Feb 21, 2019 by jkaluza.

#367 Add support for "kerberos_or_ssl" auth the same way as we do in ODCS.

master 0

Merged Feb 18, 2019. Opened Feb 15, 2019 by jkaluza.

#366 Ensure that Event.id is always set after `Event.get_or_create_from_event()`.

master 0

Merged Feb 22, 2019. Opened Feb 13, 2019 by jkaluza.

#365 Rejuvente monitor module

master 0

Merged Feb 11, 2019. Opened Feb 8, 2019 by fivaldi.

#364 Fix xmlrpc import to work with python3

master 0

Merged Feb 8, 2019. Opened Feb 8, 2019 by lucarval.

#363 Add Event.requested_rebuilds to store the artifacts requested to rebuild for manual rebuild.

master 0

Merged Feb 7, 2019. Opened Feb 7, 2019 by jkaluza.

#362 Change the ArtifactBuild.rebuilt_nvr when retrying failed build.

master 0

Merged Feb 8, 2019. Opened Feb 6, 2019 by jkaluza.

#361 freshmaker-cli: Use "dep_on_id" to generate the tree, fix the prod/stage links.

master 0

Merged Feb 15, 2019. Opened Feb 6, 2019 by jkaluza.

#360 Add `internal.UpdateDBOnODCSComposeFail` handler to mark ArtifactBuilds as failed in case of ODCS compose failure.

master 0

Merged Feb 6, 2019. Opened Feb 4, 2019 by jkaluza.

#359 Tweak the BUILDING/COMPLETE Event state reasons to contain more useful info.

master 0

Merged Feb 1, 2019. Opened Feb 1, 2019 by jkaluza.

#358 Fix the M:N SQL join in RebuildImagesOnODCSComposeDone.

master 0

Merged Jan 31, 2019. Opened Jan 31, 2019 by jkaluza.

#357 Store Bob builds as new ArtifactBuildType IMAGE_REPOSITORY and handle Bob response.

master 0

Merged Jan 30, 2019. Opened Jan 30, 2019 by jkaluza.

#356 Use ArtifactBuild.dep_on to find out the rebuilt_nvr of the parent image.

master 0

Merged Feb 6, 2019. Opened Jan 28, 2019 by jkaluza.

#355 Distinguish between generic and service-specific metrrics

master 0

Merged Jan 28, 2019. Opened Jan 28, 2019 by fivaldi.

#354 Do not override "global" whitelist with handler-specific whitelist in handler.allow_build().

master 0

Merged Jan 25, 2019. Opened Jan 25, 2019 by jkaluza.

#353 Bob: Add rebuilt repository names into DB as ArtifactBuilds.

master 0

Merged Jan 28, 2019. Opened Jan 24, 2019 by jkaluza.

#352 Include full RPM manifest in unpublished images, so we can generate extra ODCS compose with them.

master 0

Merged Jan 29, 2019. Opened Jan 23, 2019 by jkaluza.

#351 Generate Pulp repos in case we are generating extra ODCS compose for unpublished image.

master 0

Merged Jan 29, 2019. Opened Jan 23, 2019 by jkaluza.

#350 The Lightblue.get_images_by_nvrs expects list as input, but we passed it str.

master 0

Merged Jan 23, 2019. Opened Jan 23, 2019 by jkaluza.

#349 Allow generating non-RPM manual advisory events. Do not run RebuildImagesOnRPMAdvisoryChange on non-RPM events.

master 0