#178 Do not use assert in Lightblue constructor
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker lb-assert  into  master

Download 178.patch

I tried my best to recall my memory of why I wrote assert here. The major reason should be just to check the value's type during development, not expect to assert the value during runtime. So, in my opinion, it would be enough to remove assert if it is necessary to handle issue #165.

Do note that it's fine to keep the assert in if it's just additional, my ticket was primarily to give information you should not depend on this for security purposes :).

:+1: from me, either way. ;) It is your call to make, @cqi.

On Mon, 2018-01-08 at 15:29 +0000, Ralph Bean wrote:

ralph commented on the pull-request: Do not use assert in Lightblue constructor that you are following:
:+1: from me, either way. ;) It is your call to make, @cqi.

Ok. Let's just remove the assert. :)

rebased onto 6d68255cddf08f36c21b9c92da64802e565ff787

Updated to remove assert and merging.

Commit a1ecd071 fixes this pull-request

Pull-Request has been merged by jkaluza

Pull-Request has been merged by jkaluza

Metadata