freshmaker

#26 Rebuild docker image when bodhi update moves to stable
Merged by cqi. Opened by cqi.
cqi/freshmaker rebuild-docker-image-when-update-stable  into  master

Download 26.patch

This is also for original issue that is to rebuild docker image when
RPMs are built/tagged. Since building docker image should get RPMs from
official Fedora repositories, freshmaker has to wait for message of
topic bodhi.update.complete.stable.

Signed-off-by: Chenxiong Qi cqi@redhat.com

Using itertools.chain. :rainbow: :yellow_heart:

This looks good to me! Nice work.

/cc @bowlofeggs and @maxamillion for visibility.

rebased

I think you should move this method into utils.py as _run_command is a private module method and should not be imported here from the perspective of best practices. Another benefit is you can pass logger=logger which would make debug easier if something is going wrong.

Hi mjia, clone_repository is specific to DockerImageRebuildHandlerForBodhi. And, there is also a background of why I considered to put this method here at current stage. In utils.py, there is a similar method that clones a module repository from dist-git. Ideally, both of it and this method clone_repository could be merged into one, that is what I'm doing in my local branch. :) Once it is done and ready for review, I'll make a PR.

Okay, it makes sense to me.

+1

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.