@cqi there are conflicts, can you fix them?

@gnaponie Rebased and fixed the conflicts. PTAL.

dict doesn't accept non-keyworded arguments.

+1 (+ what @qwan said.)

@cqi could you please solve the commits also here? Then we can merge this. Thank you

@cqi ping?

Sorry for late response. Patch is rebased and conflicts are fixed.

@qwan @jkaluza

The *args is for the case ContainerImage({...}).

Tests are fixed.

Can you update this? because dict expect at most one argument, and it can accept either one argument or name=value pairs, but not both.

One minor comment, other looks good to me.

Can you update this? because dict expect at most one argument, and it can accept either one argument or name=value pairs, but not both.

This __init__ inherits the ability of dict to initialize an object in these two ways:

image = ContainerImage({...})
image = ContainerImage(name=.., version=.., ...)

To keep the usage flexible, I'd like to keep this basic ability for ContainerImage as well.

To keep the usage flexible, I'd like to keep this basic ability for ContainerImage as well.

Since both dict.__init__ and dict.update don't accept multiple arguments, it doesn't make sense to have such code. I'd suggest something like:

    def __init__(self, data=None, **kwargs):
        super().__init__(**kwargs)
        if data:
            self.update(data)

minor: I'd remove the '/' between 'brew/build'

Just a minor comment, but it looks good to me +1

Freshmaker has been migrated to GitHub. Please reopen your PR on GitHub.