freshmaker

#93 Add DRY_RUN option to not submit real builds, but instead fake them. Also fix bug when build_id of submitted build was not recorded in db.
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker dry-run-fixes  into  master

Download 93.patch
no initial comment

I recommend wrapping this fake_compose stuff up into a function so that it doesn't clutter this longer function.

Same here as above. I recommend wrapping this fake BuildContainer stuff up into a function. It is not central to what this function is about, and the length of the code (~10 lines) obscures the function's theme for a reader of the code.

One stylistic change requested.

rebased onto 3d0eb8f41946c21ae684e8d439c959fabbb73311

2 new commits added

  • Move dry run mode fake calls to separate methods.
  • Add DRY_RUN option to not submit real builds, but instead fake them. Also fix bug when build_id of submitted build was not recorded in db.

1 new commit added

  • Do not create multiple ErrataAdvisoryRPMsSignedEvents for single Errata advisory.

2 new commits added

  • Move dry run mode fake calls to separate methods.
  • Add DRY_RUN option to not submit real builds, but instead fake them. Also fix bug when build_id of submitted build was not recorded in db.

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.